github-actions[bot] commented on code in PR #25138:
URL: https://github.com/apache/doris/pull/25138#discussion_r1354273370


##########
be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:
##########
@@ -476,6 +480,16 @@ Status ScalarColumnReader::_try_load_dict_page(bool* 
loaded, bool* has_dict) {
 Status ScalarColumnReader::read_column_data(ColumnPtr& doris_column, 
DataTypePtr& type,
                                             ColumnSelectVector& select_vector, 
size_t batch_size,
                                             size_t* read_rows, bool* eof, bool 
is_dict_filter) {
+    bool need_convert = false;
+    auto & physical_type = _chunk_meta.meta_data.type;
+    DataTypePtr src_type;
+    ParquetConvert::convert_data_type_from_parquet(physical_type, 
src_type,type,&need_convert);
+
+    ColumnPtr src_column = doris_column;

Review Comment:
   warning: variable 'src_column' is not initialized 
[cppcoreguidelines-init-variables]
   
   ```suggestion
       ColumnPtr src_column = 0 = doris_column;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to