github-actions[bot] commented on code in PR #25269:
URL: https://github.com/apache/doris/pull/25269#discussion_r1354109820
##########
be/src/pipeline/exec/set_probe_sink_operator.h:
##########
@@ -45,7 +42,7 @@ class SetProbeSinkOperatorBuilder final
public:
SetProbeSinkOperatorBuilder(int32_t id, int child_id, ExecNode* set_node);
- [[nodiscard]] bool is_sink() const override { return true; }
+ bool is_sink() const override { return true; }
Review Comment:
warning: function 'is_sink' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_sink() const override { return true; }
```
##########
be/src/pipeline/exec/union_source_operator.h:
##########
@@ -136,7 +136,7 @@ class UnionSourceOperatorX final : public
OperatorX<UnionSourceLocalState> {
}
return Status::OK();
}
- [[nodiscard]] int get_child_count() const { return _child_size; }
+ int get_child_count() const { return _child_size; }
Review Comment:
warning: function 'get_child_count' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] int get_child_count() const { return _child_size; }
```
##########
be/src/pipeline/exec/set_source_operator.h:
##########
@@ -39,7 +38,7 @@ class SetSourceOperatorBuilder
public:
SetSourceOperatorBuilder(int32_t id, ExecNode* set_node);
- [[nodiscard]] bool is_source() const override { return true; }
+ bool is_source() const override { return true; }
Review Comment:
warning: function 'is_source' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_source() const override { return true; }
```
##########
be/src/pipeline/exec/set_sink_operator.h:
##########
@@ -43,7 +36,7 @@ class SetSinkOperatorBuilder final
public:
SetSinkOperatorBuilder(int32_t id, ExecNode* set_node);
- [[nodiscard]] bool is_sink() const override { return true; }
+ bool is_sink() const override { return true; }
Review Comment:
warning: function 'is_sink' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_sink() const override { return true; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
