github-actions[bot] commented on code in PR #25233:
URL: https://github.com/apache/doris/pull/25233#discussion_r1352586850
##########
be/src/runtime/runtime_state.h:
##########
@@ -356,10 +356,7 @@ class RuntimeState {
return _query_options.__isset.skip_delete_bitmap &&
_query_options.skip_delete_bitmap;
}
- bool enable_page_cache() const {
- return !config::disable_storage_page_cache &&
- (_query_options.__isset.enable_page_cache &&
_query_options.enable_page_cache);
- }
+ bool enable_page_cache() const;
Review Comment:
warning: function 'enable_page_cache' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool enable_page_cache() const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
