github-actions[bot] commented on code in PR #25230: URL: https://github.com/apache/doris/pull/25230#discussion_r1351875381
########## be/src/service/point_query_executor.h: ########## @@ -82,6 +82,8 @@ class Reusable { return _col_uid_to_idx; } + const std::vector<std::string>& get_col_default_values() const { return _col_default_values; } Review Comment: warning: function 'get_col_default_values' should be marked [[nodiscard]] [modernize-use-nodiscard] ```suggestion [[nodiscard]] const std::vector<std::string>& get_col_default_values() const { return _col_default_values; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org