chaoyli commented on a change in pull request #4990:
URL: https://github.com/apache/incubator-doris/pull/4990#discussion_r533153262
##########
File path: be/src/exec/es/es_query_builder.cpp
##########
@@ -50,19 +50,39 @@ void ESQueryBuilder::to_json(rapidjson::Document* document,
rapidjson::Value* qu
}
TermQueryBuilder::TermQueryBuilder(const std::string& field, const
std::string& term)
- : _field(field), _term(term) {}
+ : _field(field), _term(term), _match_none(false) {}
TermQueryBuilder::TermQueryBuilder(const ExtBinaryPredicate& binary_predicate)
- : _field(binary_predicate.col.name),
_term(binary_predicate.value.to_string()) {}
+ : _field(binary_predicate.col.name), _match_none(false) {
+ if (binary_predicate.col.type.type == PrimitiveType::TYPE_BOOLEAN) {
+ int val = atoi(binary_predicate.value.to_string().c_str());
Review comment:
use StringParse::string_to_int instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
