englefly commented on code in PR #25169:
URL: https://github.com/apache/doris/pull/25169#discussion_r1350091180
##########
regression-test/suites/nereids_function_p0/scalar_function/L.groovy:
##########
@@ -91,4 +91,8 @@ suite("nereids_scalar_fn_L") {
qt_sql_ltrim_Varchar_notnull "select ltrim(kvchrs1) from
fn_test_not_nullable order by kvchrs1"
qt_sql_ltrim_String "select ltrim(kstr) from fn_test order by kstr"
qt_sql_ltrim_String_notnull "select ltrim(kstr) from
fn_test_not_nullable order by kstr"
+ qt_sql_ltrim_Varchar_Varchar "select ltrim(kvchrs1, 'constant') from
fn_test order by kvchrs1"
Review Comment:
this case can not verify the function of ltrim.
It would be better if we replace "constant" to "var"
select ltrim(kvchrs1, 'var') from fn_test order by kvchrs1
then we get output "char11" instead of original value "varchar11"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
