morningman commented on a change in pull request #4964:
URL: https://github.com/apache/incubator-doris/pull/4964#discussion_r531827194
##########
File path: be/src/olap/compaction.cpp
##########
@@ -164,17 +173,11 @@ void Compaction::modify_rowsets() {
_tablet->save_meta();
}
-OLAPStatus Compaction::gc_unused_rowsets() {
+void Compaction::gc_output_rowset() {
Review comment:
`gc_output_rowset()` should only be called when compaction succeed.
In #4212, we have implemented a new compaction logic, so that the input
rowset will be deleted later. And we only need to delete the output rowset when
failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
