github-actions[bot] commented on code in PR #25120:
URL: https://github.com/apache/doris/pull/25120#discussion_r1349646710


##########
be/src/pipeline/exec/multi_cast_data_stream_source.h:
##########
@@ -163,6 +161,12 @@ class MultiCastDataStreamerSourceOperatorX final
 
     bool is_source() const override { return true; }
 
+    const std::vector<TRuntimeFilterDesc>& runtime_filter_descs() override {
+        return _t_data_stream_sink.runtime_filters;
+    }
+
+    int dest_id_from_sink() const { return _t_data_stream_sink.dest_node_id; }

Review Comment:
   warning: function 'dest_id_from_sink' should be marked [[nodiscard]] 
[modernize-use-nodiscard]
   
   ```suggestion
       [[nodiscard]] int dest_id_from_sink() const { return 
_t_data_stream_sink.dest_node_id; }
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to