github-actions[bot] commented on code in PR #25084:
URL: https://github.com/apache/doris/pull/25084#discussion_r1349637656
##########
be/src/util/runtime_profile.h:
##########
@@ -368,6 +368,15 @@ class RuntimeProfile {
bool is_set_metadata() const { return _is_set_metadata; }
+ void set_is_sink(bool is_sink) {
+ _is_set_sink = true;
+ _is_sink = is_sink;
+ }
+
+ bool is_sink() const { return _is_sink; }
+
+ bool is_set_sink() const { return _is_set_sink; }
Review Comment:
warning: function 'is_set_sink' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_set_sink() const { return _is_set_sink; }
```
##########
be/src/util/runtime_profile.h:
##########
@@ -368,6 +368,15 @@ class RuntimeProfile {
bool is_set_metadata() const { return _is_set_metadata; }
+ void set_is_sink(bool is_sink) {
+ _is_set_sink = true;
+ _is_sink = is_sink;
+ }
+
+ bool is_sink() const { return _is_sink; }
Review Comment:
warning: function 'is_sink' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_sink() const { return _is_sink; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
