morningman commented on code in PR #24990:
URL: https://github.com/apache/doris/pull/24990#discussion_r1349532110
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java:
##########
@@ -130,6 +130,11 @@ public String toSql() {
return toString();
}
+ @Override
+ protected String getExpressionName() {
+ return "literal";
Review Comment:
Same as `Expression.getExpressionName()`?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Expression.java:
##########
@@ -49,9 +50,10 @@
* Abstract class for all Expression in Nereids.
*/
public abstract class Expression extends AbstractTreeNode<Expression>
implements ExpressionTrait {
+ public static final String DEFAULT_EXPRESSION_NAME = "__expression";
Review Comment:
Why this is different from Expr.DEFAULT_EXPR_NAME?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Variable.java:
##########
@@ -47,6 +47,11 @@ public String getName() {
return name;
}
+ @Override
+ protected String getExpressionName() {
Review Comment:
Seems same as Expression.getExpressionName()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
