liugddx commented on PR #25033: URL: https://github.com/apache/doris/pull/25033#issuecomment-1751691976
> does new checker's rules TOTALLY same as original checkstyle rules? if not same, please desc what different between two of them. there are too many check to avoid wrong code and ensure easy reading in checkstyle rules, u should impl all of them in new checker before remove checkstyle rules. furthermore, u should explain the purpose of replacing spotless with checkstyle - `import-control` is done through replaceRegex https://github.com/diffplug/spotless/issues/649 - `Suppressions.xml` is not required under the spotless plugin. Other rules can use spotless directly. If you have any other verification rules that you are interested in, please send them to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
