github-actions[bot] commented on code in PR #24998:
URL: https://github.com/apache/doris/pull/24998#discussion_r1349494302
##########
be/src/vec/runtime/vparquet_transformer.cpp:
##########
@@ -286,15 +204,14 @@
VParquetTransformer::VParquetTransformer(doris::io::FileWriter* file_writer,
const TParquetVersion::type&
parquet_version,
bool output_object_data)
: VFileFormatTransformer(output_vexpr_ctxs, output_object_data),
- _rg_writer(nullptr),
_parquet_schemas(parquet_schemas),
_compression_type(compression_type),
_parquet_disable_dictionary(parquet_disable_dictionary),
_parquet_version(parquet_version) {
_outstream = std::shared_ptr<ParquetOutputStream>(new
ParquetOutputStream(file_writer));
}
-Status VParquetTransformer::parse_properties() {
+Status VParquetTransformer::_parse_properties() {
Review Comment:
warning: method '_parse_properties' can be made const
[readability-make-member-function-const]
```suggestion
Status VParquetTransformer::_parse_properties() const {
```
be/src/vec/runtime/vparquet_transformer.h:109:
```diff
- Status _parse_properties();
+ Status _parse_properties() const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
