qidaye commented on code in PR #24826: URL: https://github.com/apache/doris/pull/24826#discussion_r1349492536
########## regression-test/suites/external_table_p0/es/test_es_query.groovy: ########## @@ -158,6 +187,17 @@ suite("test_es_query", "p0,external,es,external_docker,external_docker_es") { order_qt_sql77 """select * from test1 where esquery(test2, '{"match":{"test2":"text#1"}}')""" order_qt_sql78 """select c_bool, c_byte, c_short, c_integer, c_long, c_unsigned_long, c_float, c_half_float, c_double, c_scaled_float, c_date, c_datetime, c_keyword, c_text, c_ip, c_person from test1""" order_qt_sql79 """select c_bool, c_byte, c_short, c_integer, c_long, c_unsigned_long, c_float, c_half_float, c_double, c_scaled_float, c_date, c_datetime, c_keyword, c_text, c_ip, c_person from test2""" + + sql """switch es7_hide""" Review Comment: It would be better to add a list es7 for comparison. ########## regression-test/suites/external_table_p0/es/test_es_query.groovy: ########## @@ -148,6 +166,17 @@ suite("test_es_query", "p0,external,es,external_docker,external_docker_es") { order_qt_sql67 """select * from test1 where esquery(test2, '{"match":{"test2":"text#1"}}')""" order_qt_sql68 """select c_bool, c_byte, c_short, c_integer, c_long, c_unsigned_long, c_float, c_half_float, c_double, c_scaled_float, c_date, c_datetime, c_keyword, c_text, c_ip, c_person from test1""" order_qt_sql69 """select c_bool, c_byte, c_short, c_integer, c_long, c_unsigned_long, c_float, c_half_float, c_double, c_scaled_float, c_date, c_datetime, c_keyword, c_text, c_ip, c_person from test2_20220808""" + + sql """switch es6_hide""" Review Comment: It would be better to add a list es6 tables for comparison. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org