morningman commented on code in PR #24830:
URL: https://github.com/apache/doris/pull/24830#discussion_r1347558295
##########
docs/zh-CN/docs/lakehouse/multi-catalog/hive.md:
##########
@@ -380,6 +380,14 @@ CREATE CATALOG hive PROPERTIES (
该变量默认为 false。
+## 使用 broker 访问 HMS
+
+创建 HMS Catalog 时增加如下配置，Hive 外表文件分片和文件扫描将会由名为 `test_broekr` 的 broker 完成
Review Comment:
```suggestion
创建 HMS Catalog 时增加如下配置，Hive 外表文件分片和文件扫描将会由名为 `test_broker` 的 broker 完成
```
##########
gensrc/thrift/PaloBrokerService.thrift:
##########
@@ -91,12 +91,25 @@ struct TBrokerCheckPathExistResponse {
2: required bool isPathExist;
}
+struct TBrokerIsSplittableResponse {
+ 1: optional TBrokerOperationStatus opStatus;
+ 2: optional bool splittable;
+}
+
struct TBrokerListPathRequest {
1: required TBrokerVersion version;
2: required string path;
3: required bool isRecursive;
4: required map<string,string> properties;
5: optional bool fileNameOnly;
+ 6: optional bool onlyFiles;
+}
+
+struct TBrokerIsSplittableRequest {
+ 1: required TBrokerVersion version;
+ 2: required string path;
+ 3: required string inputFormat;
+ 4: required map<string,string> properties;
Review Comment:
use `optional` for all fields
##########
docs/zh-CN/docs/lakehouse/multi-catalog/hive.md:
##########
@@ -380,6 +380,14 @@ CREATE CATALOG hive PROPERTIES (
该变量默认为 false。
+## 使用 broker 访问 HMS
+
+创建 HMS Catalog 时增加如下配置，Hive 外表文件分片和文件扫描将会由名为 `test_broekr` 的 broker 完成
Review Comment:
```suggestion
创建 HMS Catalog 时增加如下配置，Hive 外表文件分片和文件扫描将会由名为 `test_broker` 的 broker 完成
```
##########
docs/en/docs/lakehouse/multi-catalog/hive.md:
##########
@@ -401,6 +401,14 @@ If the variable `truncate_char_or_varchar_columns` is
enabled, when the maximum
The variable default is false.
+## Access HMS with broker
+
+Add following setting when creating an HMS catalog, file splitting and
scanning for Hive external table will be completed by broker named `test_broekr`
Review Comment:
```suggestion
Add following setting when creating an HMS catalog, file splitting and
scanning for Hive external table will be completed by broker named `test_broker`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
