yiguolei commented on code in PR #25030:
URL: https://github.com/apache/doris/pull/25030#discussion_r1346086870
##########
gensrc/thrift/Exprs.thrift:
##########
@@ -52,9 +52,12 @@ enum TExprNodeType {
// only used in runtime filter
BLOOM_PRED,
- // for josn
+ // for json
JSON_LITERAL,
+ // for geo
Review Comment:
always add the new element at the end of the enum definition.
##########
gensrc/thrift/Exprs.thrift:
##########
@@ -178,6 +181,10 @@ struct TJsonLiteral {
1: required string value;
}
+struct TGeometryLiteral {
+ 1: required binary value;
Review Comment:
never use required field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
