This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new d23bedf170 [fix](single-replica-load) fix duplicated done run in
request_slave_tablet_pull_rowset (#25013)
d23bedf170 is described below
commit d23bedf1700c249c00fcd9f60d98e7f0b24e11a6
Author: zhengyu <freeman.zhang1...@gmail.com>
AuthorDate: Thu Sep 28 21:08:18 2023 +0800
[fix](single-replica-load) fix duplicated done run in
request_slave_tablet_pull_rowset (#25013)
BE will crash because done run twice when try_offer() failed in
request_slave_tablet_pull_rowset.
Signed-off-by: freemandealer <freeman.zhang1...@gmail.com>
---
be/src/service/internal_service.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/be/src/service/internal_service.cpp
b/be/src/service/internal_service.cpp
index 6ef5066d3b..28181fb90f 100644
--- a/be/src/service/internal_service.cpp
+++ b/be/src/service/internal_service.cpp
@@ -1501,7 +1501,7 @@ void
PInternalServiceImpl::request_slave_tablet_pull_rowset(
rowset_meta->tablet_id(), node_id, true);
});
if (!ret) {
- offer_failed(response, done, _heavy_work_pool);
+ offer_failed(response, closure_guard.release(), _heavy_work_pool);
return;
}
Status::OK().to_protobuf(response->mutable_status());
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
