freemandealer commented on code in PR #25013:
URL: https://github.com/apache/doris/pull/25013#discussion_r1339989567
##########
be/src/service/internal_service.cpp:
##########
@@ -1498,7 +1498,7 @@ void
PInternalServiceImpl::request_slave_tablet_pull_rowset(
rowset_meta->tablet_id(), node_id, true);
});
if (!ret) {
- offer_failed(response, done, _heavy_work_pool);
Review Comment:
Unlike other RPC impl, true response of pull rowset operation is sent to the
caller by a new RPC called `response_slave_tablet_pull_rowset`. So here, we
need to acknowledge the current `request_slave_tablet_pull_rowset` ASAP. We do
need more discussion here to decide how we can fix it decently (and more on the
thread pool single replica load is using). Let's freeze this PR for a while.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
