JingDas commented on code in PR #24990:
URL: https://github.com/apache/doris/pull/24990#discussion_r1339879994
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyticExpr.java:
##########
@@ -144,6 +145,11 @@ public AnalyticWindow getWindow() {
return window;
}
+ @Override
+ protected String getExprName() {
+ return Expression.normalizeColumnName(getFnCall().getExprName());
Review Comment:
I rethink this method, the actual mean of the method is normalize the name
of expression or expr. and
it should be independent of column domain or other. So I think should rename
it to normalizeName to match the actual meaning for normalize the
expr(expression name). WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
