yiguolei commented on code in PR #25007:
URL: https://github.com/apache/doris/pull/25007#discussion_r1339838594
##########
be/src/vec/columns/column_dictionary.h:
##########
@@ -205,22 +205,6 @@ class ColumnDictionary final : public COWHelper<IColumn,
ColumnDictionary<T>> {
LOG(FATAL) << "index not implemented";
}
- Status filter_by_selector(const uint16_t* sel, size_t sel_size, IColumn*
col_ptr) override {
Review Comment:
这个我觉得不能删
##########
be/src/vec/columns/column_dictionary.h:
##########
@@ -205,22 +205,6 @@ class ColumnDictionary final : public COWHelper<IColumn,
ColumnDictionary<T>> {
LOG(FATAL) << "index not implemented";
}
- Status filter_by_selector(const uint16_t* sel, size_t sel_size, IColumn*
col_ptr) override {
Review Comment:
这个我觉得不能删
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
