github-actions[bot] commented on code in PR #25006:
URL: https://github.com/apache/doris/pull/25006#discussion_r1339735205
##########
be/src/gutil/strings/numbers.cc:
##########
@@ -1275,6 +1277,10 @@ int FloatToBuffer(float value, int width, char* buffer) {
}
int FastDoubleToBuffer(double value, char* buffer) {
+ int ret = jkj::dragonbox::to_chars_n(value, buffer) - buffer;
+ if (LIKELY(ret > 0))
+ return ret;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (LIKELY(ret > 0)) {
return ret;
}
```
##########
be/src/gutil/strings/numbers.cc:
##########
@@ -1284,6 +1290,10 @@ int FastDoubleToBuffer(double value, char* buffer) {
}
int FastFloatToBuffer(float value, char* buffer) {
+ int ret = jkj::dragonbox::to_chars_n(value, buffer) - buffer;
+ if (LIKELY(ret > 0))
+ return ret;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (LIKELY(ret > 0)) {
return ret;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
