github-actions[bot] commented on code in PR #24929:
URL: https://github.com/apache/doris/pull/24929#discussion_r1337234847
##########
be/src/olap/rowset_builder.h:
##########
@@ -77,7 +78,7 @@ class RowsetBuilder {
std::shared_ptr<RowsetWriter> rowset_writer() const { return
_rowset_writer; }
- TabletSharedPtr tablet() const { return _tablet; }
+ BaseTabletSPtr tablet() const { return _tablet; }
Review Comment:
warning: function 'tablet' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] BaseTabletSPtr tablet() const { return _tablet; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
