WinkerDu commented on code in PR #24830: URL: https://github.com/apache/doris/pull/24830#discussion_r1336836934
########## fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java: ########## @@ -1062,6 +1064,49 @@ public BrokerFileSystem getGooseFSFileSystem(String path, Map<String, String> pr } } + public List<TBrokerFileStatus> listLocatedFiles(String path, boolean onlyFiles, Review Comment: 1. `listPath` method in broker uses `FileSystem.globStatus` to access underlying file system, `FileSystem.globStatus` doesn't expose `recursive` option for only-file file listing. Otherwise, `listLocatedFiles` here uses `FileSystem.listFiles` to access file system, which exposes `recursive` option. 2. Make it consistent with the action in `RemoteFileSystem.listLocatedFiles` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org