github-actions[bot] commented on code in PR #24873:
URL: https://github.com/apache/doris/pull/24873#discussion_r1335715461
##########
be/src/vec/columns/column_array.h:
##########
@@ -227,12 +227,32 @@ class ColumnArray final : public COWHelper<IColumn,
ColumnArray> {
void insert_indices_from(const IColumn& src, const int* indices_begin,
const int* indices_end) override;
- void replace_column_data(const IColumn&, size_t row, size_t self_row = 0)
override {
- LOG(FATAL) << "replace_column_data not implemented";
+ void replace_column_data(const IColumn& rhs, size_t row, size_t self_row =
0) override {
Review Comment:
warning: method 'replace_column_data' can be made const
[readability-make-member-function-const]
```suggestion
void replace_column_data(const IColumn& rhs, size_t row, size_t self_row
= 0) const override {
```
##########
be/src/vec/columns/column_struct.h:
##########
@@ -130,11 +131,31 @@ class ColumnStruct final : public COWHelper<IColumn,
ColumnStruct> {
void append_data_by_selector(MutableColumnPtr& res, const Selector&
selector) const override {
return append_data_by_selector_impl<ColumnStruct>(res, selector);
}
- void replace_column_data(const IColumn&, size_t row, size_t self_row = 0)
override {
- LOG(FATAL) << "replace_column_data not implemented";
+ void replace_column_data(const IColumn& rhs, size_t row, size_t self_row =
0) override {
Review Comment:
warning: method 'replace_column_data' can be made const
[readability-make-member-function-const]
```suggestion
void replace_column_data(const IColumn& rhs, size_t row, size_t self_row
= 0) const override {
```
##########
be/src/vec/columns/column_nullable.h:
##########
@@ -357,6 +357,25 @@ class ColumnNullable final : public COWHelper<IColumn,
ColumnNullable> {
}
}
+ void replace_batch_column_data(const IColumn& rhs, size_t num_rows, size_t
row,
Review Comment:
warning: method 'replace_batch_column_data' can be made const
[readability-make-member-function-const]
be/src/vec/columns/column_nullable.h:360:
```diff
- size_t self_row = 0) override {
+ size_t self_row = 0) const override {
```
##########
be/src/vec/columns/column_map.h:
##########
@@ -140,11 +140,34 @@ class ColumnMap final : public COWHelper<IColumn,
ColumnMap> {
return append_data_by_selector_impl<ColumnMap>(res, selector);
}
- void replace_column_data(const IColumn&, size_t row, size_t self_row = 0)
override {
- LOG(FATAL) << "replace_column_data not implemented";
+ void replace_column_data(const IColumn& rhs, size_t row, size_t self_row =
0) override {
Review Comment:
warning: method 'replace_column_data' can be made const
[readability-make-member-function-const]
```suggestion
void replace_column_data(const IColumn& rhs, size_t row, size_t self_row
= 0) const override {
```
##########
be/src/vec/columns/column_struct.h:
##########
@@ -130,11 +131,31 @@ class ColumnStruct final : public COWHelper<IColumn,
ColumnStruct> {
void append_data_by_selector(MutableColumnPtr& res, const Selector&
selector) const override {
return append_data_by_selector_impl<ColumnStruct>(res, selector);
}
- void replace_column_data(const IColumn&, size_t row, size_t self_row = 0)
override {
- LOG(FATAL) << "replace_column_data not implemented";
+ void replace_column_data(const IColumn& rhs, size_t row, size_t self_row =
0) override {
+ DCHECK(size() > self_row);
+ const auto& r = assert_cast<const ColumnStruct&>(rhs);
+
+ for (size_t idx = 0; idx < columns.size(); ++idx) {
+ columns[idx]->replace_column_data(r.get_column(idx), row,
self_row);
+ }
}
+
+ void replace_batch_column_data(const IColumn& rhs, size_t num_rows, size_t
row,
Review Comment:
warning: method 'replace_batch_column_data' can be made const
[readability-make-member-function-const]
be/src/vec/columns/column_struct.h:143:
```diff
- size_t self_row = 0) override {
+ size_t self_row = 0) const override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
