github-actions[bot] commented on code in PR #24862:
URL: https://github.com/apache/doris/pull/24862#discussion_r1335646190
##########
be/src/vec/functions/function_fake.h:
##########
@@ -54,6 +54,7 @@ class FunctionFake : public IFunction {
}
bool use_default_implementation_for_nulls() const override { return true; }
+ bool use_default_implementation_for_constants() const override { return
false; }
Review Comment:
warning: function 'use_default_implementation_for_constants' should be
marked [[nodiscard]] [modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool use_default_implementation_for_constants() const
override { return false; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
