github-actions[bot] commented on code in PR #24502:
URL: https://github.com/apache/doris/pull/24502#discussion_r1335126707
##########
be/src/http/ev_http_server.h:
##########
@@ -53,7 +53,7 @@ class EvHttpServer {
int on_header(struct evhttp_request* ev_req);
// get real port
- int get_real_port() { return _real_port; }
+ int get_real_port() const { return _real_port; }
Review Comment:
warning: function 'get_real_port' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] int get_real_port() const { return _real_port; }
```
##########
be/src/service/http_service.h:
##########
@@ -37,6 +37,9 @@ class HttpService {
Status start();
void stop();
+ // get real port
+ int get_real_port() const;
Review Comment:
warning: function 'get_real_port' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] int get_real_port() const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
