yiguolei commented on code in PR #24791:
URL: https://github.com/apache/doris/pull/24791#discussion_r1335023593
##########
regression-test/suites/query_p0/sql_functions/math_functions/test_round.groovy:
##########
@@ -21,6 +21,11 @@
qt_select "SELECT round_bankers(10.12345)"
qt_select "SELECT round_bankers(10.12345, 2)"
+ // test tie case 1: float, banker's rounding
+ qt_select "SELECT number*10/100, ROUND(number * 10 / 100) from
NUMBERS('number'=50) where number % 5 = 0;"
Review Comment:
add order by please. Or the result is not stable, and the workflow may
failed.
##########
regression-test/suites/query_p0/sql_functions/math_functions/test_round.groovy:
##########
@@ -21,6 +21,11 @@
qt_select "SELECT round_bankers(10.12345)"
qt_select "SELECT round_bankers(10.12345, 2)"
+ // test tie case 1: float, banker's rounding
+ qt_select "SELECT number*10/100, ROUND(number * 10 / 100) from
NUMBERS('number'=50) where number % 5 = 0;"
+ // test tie case 2: decimal, rounded up when tie
+ qt_select "SELECT number*10/100, ROUND(CAST(number * 10 AS
DECIMALV3(10,2)) / 100) from NUMBERS('number'=50) where number % 5 = 0"
Review Comment:
and here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
