github-actions[bot] commented on code in PR #24613: URL: https://github.com/apache/doris/pull/24613#discussion_r1334911898
########## be/src/runtime/stream_load/stream_load_executor.cpp: ########## @@ -321,9 +321,12 @@ Status StreamLoadExecutor::operate_txn_2pc(StreamLoadContext* ctx) { TLoadTxn2PCRequest request; set_request_auth(&request, ctx->auth); request.__set_db(ctx->db); - request.__set_txnId(ctx->txn_id); request.__set_operation(ctx->txn_operation); request.__set_thrift_rpc_timeout_ms(config::txn_commit_rpc_timeout_ms); + request.__set_label(ctx->label); + if (ctx->txn_id != ctx->default_txn_id) { Review Comment: warning: static member accessed through instance [readability-static-accessed-through-instance] ```suggestion if (ctx->txn_id != doris::StreamLoadContext::default_txn_id) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org