XieJiann commented on code in PR #24764:
URL: https://github.com/apache/doris/pull/24764#discussion_r1334280226
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/stats/FilterEstimation.java:
##########
@@ -386,6 +387,19 @@ public Statistics visitNot(Not not, EstimationContext
context) {
return statisticsBuilder.build();
}
+ @Override
+ public Statistics visitIsNull(IsNull isNull, EstimationContext context) {
+ ColumnStatistic childStats =
ExpressionEstimation.estimate(isNull.child(), context.statistics);
+ if (childStats.isUnKnown()) {
+ return new StatisticsBuilder(context.statistics).build();
+ }
+ double outputRowCount = context.statistics.getRowCount() -
childStats.numNulls;
+ StatisticsBuilder builder = new StatisticsBuilder(context.statistics);
Review Comment:
isNull output nulls, so the rowCount is childStast.numNulls?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
