[GitHub] [doris] englefly commented on a diff in pull request #24672: [fix](optimizer) Fix data size calculation of auto sample

[via GitHub]

englefly commented on code in PR #24672:
URL: https://github.com/apache/doris/pull/24672#discussion_r1333926638


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##########
@@ -1568,14 +1568,18 @@ public Partition replacePartition(Partition 
newPartition) {
         return oldPartition;
     }
 
-    public long getDataSize() {
+    public long getDataSize(boolean singleReplica) {
         long dataSize = 0;
         for (Partition partition : getAllPartitions()) {
-            dataSize += partition.getDataSize(false);
+            dataSize += partition.getDataSize(singleReplica);

Review Comment:
   在这里判断数据类型，如果是定长字段，就不需要在这里for 循环累加



##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##########
@@ -1568,14 +1568,18 @@ public Partition replacePartition(Partition 
newPartition) {
         return oldPartition;
     }
 
-    public long getDataSize() {
+    public long getDataSize(boolean singleReplica) {
         long dataSize = 0;
         for (Partition partition : getAllPartitions()) {
-            dataSize += partition.getDataSize(false);
+            dataSize += partition.getDataSize(singleReplica);

Review Comment:
   在这里判断数据类型，如果是定长字段，就不需要在这里for 循环累加



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org