github-actions[bot] commented on code in PR #24751:
URL: https://github.com/apache/doris/pull/24751#discussion_r1333882298
##########
be/src/vec/functions/function_tokenize.cpp:
##########
@@ -95,13 +95,14 @@ void FunctionTokenize::_do_tokenize(const ColumnString&
src_column_string,
dest_offsets.push_back(dest_pos);
continue;
}
- std::vector<std::wstring> query_tokens =
+ auto reader = doris::segment_v2::InvertedIndexReader::create_reader(
+ &inverted_index_ctx, tokenize_str.to_string());
+
+ std::vector<std::string> query_tokens =
Review Comment:
warning: variable 'query_tokens' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
std::vector<std::string> query_tokens = 0 =
```
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.cpp:
##########
@@ -282,18 +294,18 @@ Status FullTextIndexReader::query(OlapReaderStatistics*
stats, RuntimeState* run
if (query_type == InvertedIndexQueryType::MATCH_PHRASE_QUERY ||
query_type == InvertedIndexQueryType::MATCH_ALL_QUERY ||
query_type == InvertedIndexQueryType::EQUAL_QUERY) {
- std::wstring wstr_tokens;
+ std::string str_tokens;
Review Comment:
warning: variable 'str_tokens' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
std::string str_tokens = 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
