ccoffline commented on pull request #4836: URL: https://github.com/apache/incubator-doris/pull/4836#issuecomment-723740942
@morningman I think cast `CastExpr` to `LiteralExpr` will definitely cause an exception. I just don't know whether `getResultValue()` will solve that though I didn't see anything wrong in the test. https://github.com/apache/incubator-doris/blob/b1c1ffda4a0d5ff2f0be4f9d2f25997a31537ea8/fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionKey.java#L135-L150 I'm not fully understand the logic in `partition pruner`. Maybe it should be in another PR=.= ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
