kangkaisen commented on a change in pull request #3025: URL: https://github.com/apache/incubator-doris/pull/3025#discussion_r516385798
########## File path: be/src/olap/collection.h ########## @@ -0,0 +1,50 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <iostream> + +namespace doris { + +// cpp type for ARRAY +struct Collection { + size_t length; + // null bitmap + bool* null_signs; Review comment: You could add a has_null flag. when reading array column, if has_null is false, we could only read the data column. ########## File path: gensrc/proto/segment_v2.proto ########## @@ -151,6 +151,12 @@ message ColumnMetaPB { repeated ColumnIndexMetaPB indexes = 8; // pointer to dictionary page when using DICT_ENCODING optional PagePointerPB dict_page = 9; + + repeated ColumnMetaPB children_columns = 10; + repeated string children_column_names = 11; Review comment: OK ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
