kangkaisen commented on pull request #4771:
URL: https://github.com/apache/incubator-doris/pull/4771#issuecomment-719429892
@vagetablechicken Hi, I see what's your mean.
I agree with your interface logic. But for the method naming, I think we
would better rename it.
For `selectAlternativeTabletsForCluster` method, the nameing or comment
should let other people know we
select {tablet id, src be, dest be} at one time in this method.
For `getSrcReplicaId`, rename it to `getDeleteReplicaId` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
