github-actions[bot] commented on PR #24632:
URL: https://github.com/apache/doris/pull/24632#issuecomment-1725489258
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/6236017265";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In regression-test/pipeline/common/init_and_gen_docker_cov_cmd.sh line 51:
cd ${deploy_path}
^---------------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... ||
return' in case cd fails.
^------------^ SC2154 (warning): deploy_path is referenced but not
assigned.
^------------^ SC2086 (info): Double quote to prevent globbing and
word splitting.
Did you mean:
cd "${deploy_path}" || exit
In regression-test/pipeline/common/init_and_gen_docker_cov_cmd.sh line 53:
cmd1="${LLVM_PROFDATA} merge -o ${profdata} \"${profraw}\""
^-^ SC2089 (warning):
Quotes/backslashes will be treated literally. Use an array.
In regression-test/pipeline/common/init_and_gen_docker_cov_cmd.sh line 54:
echo $cmd1
^---^ SC2090 (warning): Quotes/backslashes in this variable will
not be respected.
^---^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^---^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
echo "${cmd1}"
In regression-test/pipeline/common/init_and_gen_docker_cov_cmd.sh line 55:
eval $cmd1
^---^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^---^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
eval "${cmd1}"
In regression-test/pipeline/common/init_and_gen_docker_cov_cmd.sh line 56:
cmd2="${LLVM_COV} show -output-dir=${report} -format=html \
^-- SC2089 (warning):
Quotes/backslashes will be treated literally. Use an array.
In regression-test/pipeline/common/init_and_gen_docker_cov_cmd.sh line 60:
echo $cmd2
^---^ SC2090 (warning): Quotes/backslashes in this variable will
not be respected.
^---^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^---^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
echo "${cmd2}"
In regression-test/pipeline/common/init_and_gen_docker_cov_cmd.sh line 67:
if [[ $@ -ge 2 ]];then
^-- SC2199 (error): Arrays implicitly concatenate in [[ ]]. Use a
loop (or explicit * instead of @).
For more information:
https://www.shellcheck.net/wiki/SC2199 -- Arrays implicitly concatenate in
...
https://www.shellcheck.net/wiki/SC2089 -- Quotes/backslashes will be
treate...
https://www.shellcheck.net/wiki/SC2090 -- Quotes/backslashes in this
variab...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- regression-test/pipeline/common/init_and_gen_docker_cov_cmd.sh.orig
+++ regression-test/pipeline/common/init_and_gen_docker_cov_cmd.sh
@@ -59,12 +59,12 @@
-object=${bin}"
echo $cmd2
#eval $cmd2
-
+
}
function main() {
init_cov_tool
- if [[ $@ -ge 2 ]];then
+ if [[ $@ -ge 2 ]]; then
case_level=$1
cluster=$2
tc_checkout_dir=$3
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
