github-actions[bot] commented on code in PR #24554:
URL: https://github.com/apache/doris/pull/24554#discussion_r1328519885
##########
be/src/udf/udf.h:
##########
@@ -79,6 +79,22 @@ class FunctionContext {
return _check_overflow_for_decimal = check_overflow_for_decimal;
}
+ void set_string_as_jsonb_string(bool string_as_jsonb_string) {
+ _string_as_jsonb_string = string_as_jsonb_string;
+ }
+
+ void set_jsonb_string_as_string(bool jsonb_string_as_string) {
+ _jsonb_string_as_string = jsonb_string_as_string;
+ }
+
+ // Cast flag, when enable string_as_jsonb_string, string casting to jsonb
will not parse string
+ // instead just insert a string literal
+ bool string_as_jsonb_string() const { return _string_as_jsonb_string; }
Review Comment:
warning: function 'string_as_jsonb_string' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool string_as_jsonb_string() const { return
_string_as_jsonb_string; }
```
##########
be/src/udf/udf.h:
##########
@@ -79,6 +79,22 @@
return _check_overflow_for_decimal = check_overflow_for_decimal;
}
+ void set_string_as_jsonb_string(bool string_as_jsonb_string) {
+ _string_as_jsonb_string = string_as_jsonb_string;
+ }
+
+ void set_jsonb_string_as_string(bool jsonb_string_as_string) {
+ _jsonb_string_as_string = jsonb_string_as_string;
+ }
+
+ // Cast flag, when enable string_as_jsonb_string, string casting to jsonb
will not parse string
+ // instead just insert a string literal
+ bool string_as_jsonb_string() const { return _string_as_jsonb_string; }
+
+ // Cast flag, when enable jsonb_string_as_string, jsonb string casting to
string will not parse string
+ // instead just insert a string literal
+ bool jsonb_string_as_string() const { return _jsonb_string_as_string; }
Review Comment:
warning: function 'jsonb_string_as_string' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool jsonb_string_as_string() const { return
_jsonb_string_as_string; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
