yangzhg commented on a change in pull request #4778:
URL: https://github.com/apache/incubator-doris/pull/4778#discussion_r511699162
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/SchemaTable.java
##########
@@ -281,6 +281,23 @@ public static Builder builder() {
.column("XA",
ScalarType.createVarchar(3))
.column("SAVEPOINTS",
ScalarType.createVarchar(3))
.build()))
+ .put("views",
+ new SchemaTable(
+ SystemIdGenerator.getNextId(),
+ "views",
+ TableType.SCHEMA,
+ builder()
+ .column("TABLE_CATALOG",
ScalarType.createVarchar(512))
+ .column("TABLE_SCHEMA",
ScalarType.createVarchar(64))
+ .column("TABLE_NAME",
ScalarType.createVarchar(64))
+ .column("VIEW_DEFINITION",
ScalarType.createVarchar(8096))
+ .column("CHECK_OPTION",
ScalarType.createVarchar(8))
+ .column("IS_UPDATABLE",
ScalarType.createVarchar(3))
+ .column("DEFINER",
ScalarType.createVarchar(77))
+ .column("SECURITY_TYPE",
ScalarType.createVarchar(7))
Review comment:
why this column length is 77, you should add a comment, this column in
mysql is 288
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
