This is an automated email from the ASF dual-hosted git repository.
zhangchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 0c30720c99 [Hotfix](merge-on-write) Fix when `DeltaWriter` don't
report `num_filtered_rows` in `TTabletCommitInfo` (#24352)
0c30720c99 is described below
commit 0c30720c99786546d9d8af66df05799995745a56
Author: bobhan1 <bh2444151...@outlook.com>
AuthorDate: Thu Sep 14 20:58:08 2023 +0800
[Hotfix](merge-on-write) Fix when `DeltaWriter` don't report
`num_filtered_rows` in `TTabletCommitInfo` (#24352)
---
be/src/vec/sink/vtablet_sink.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/be/src/vec/sink/vtablet_sink.cpp b/be/src/vec/sink/vtablet_sink.cpp
index 709fd80500..c6b9dbe673 100644
--- a/be/src/vec/sink/vtablet_sink.cpp
+++ b/be/src/vec/sink/vtablet_sink.cpp
@@ -169,7 +169,7 @@ public:
void set_tablets_filtered_rows(
const std::vector<std::pair<int64_t, int64_t>>&
tablets_filtered_rows, int64_t node_id);
int64_t num_rows_filtered() {
- CHECK(!_tablets_filtered_rows.empty());
+ DCHECK(!_tablets_filtered_rows.empty());
// the Unique table has no roll up or materilized view
// we just add up filtered rows from all partitions
return std::accumulate(_tablets_filtered_rows.cbegin(),
_tablets_filtered_rows.cend(), 0,
@@ -1860,7 +1860,7 @@ Status VOlapTableSink::close(RuntimeState* state, Status
exec_status) {
// Due to the non-determinism of compaction, the rowsets of each
replica may be different from each other on different
// BE nodes. The number of rows filtered in SegmentWriter depends
on the historical rowsets located in the correspoding
// BE node. So we check the number of rows filtered on each
succeccful BE to ensure the consistency of the current load
- if (!_write_single_replica && _schema->is_strict_mode() &&
+ if (status.ok() && !_write_single_replica &&
_schema->is_strict_mode() &&
_schema->is_partial_update()) {
if (Status st =
index_channel->check_tablet_filtered_rows_consistency(); !st.ok()) {
status = st;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
