[GitHub] [doris] morrySnow commented on a diff in pull request #21597: [feature](partial update) support MOW partial update for insert statement

[via GitHub]

morrySnow commented on code in PR #21597:
URL: https://github.com/apache/doris/pull/21597#discussion_r1325759371


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/NativeInsertStmt.java:
##########
@@ -405,8 +406,9 @@ public void analyze(Analyzer analyzer) throws UserException 
{
             OlapTableSink sink = (OlapTableSink) dataSink;
             TUniqueId loadId = analyzer.getContext().queryId();
             int sendBatchParallelism = 
analyzer.getContext().getSessionVariable().getSendBatchParallelism();
+            boolean isInsertStrict = 
analyzer.getContext().getSessionVariable().getEnableInsertStrict();
             sink.init(loadId, transactionId, db.getId(), timeoutSecond,
-                    sendBatchParallelism, false, false, isInsertIgnore);
+                    sendBatchParallelism, false, isInsertStrict, 
isInsertIgnore);            

Review Comment:
   please add this feature to nereids' dml too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org