imay commented on a change in pull request #4593:
URL: https://github.com/apache/incubator-doris/pull/4593#discussion_r506787867
##########
File path: be/src/olap/cumulative_compaction.cpp
##########
@@ -83,7 +83,18 @@ OLAPStatus CumulativeCompaction::pick_rowsets_to_compact() {
return OLAP_ERR_CUMULATIVE_NO_SUITABLE_VERSIONS;
}
- RETURN_NOT_OK(check_version_continuity(candidate_rowsets));
+ // candidate_rowsets may not be continuous. Because some rowset may not be
selected
+ // because the protection time has not
expired(config::cumulative_compaction_skip_window_seconds).
+ // So we need to choose the longest continuous path from it.
+ std::vector<Version> missing_versions;
+ RETURN_NOT_OK(find_longest_consecutive_version(&candidate_rowsets,
&missing_versions));
+ if (missing_versions.empty()) {
Review comment:
```suggestion
if (!missing_versions.empty()) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
