zhannngchen commented on code in PR #21773:
URL: https://github.com/apache/doris/pull/21773#discussion_r1324018895


##########
fe/fe-core/src/test/java/org/apache/doris/planner/OlapTableSinkTest.java:
##########
@@ -206,7 +206,7 @@ public void testListPartition(
         };
 
         OlapTableSink sink = new OlapTableSink(dstTable, tuple, 
Lists.newArrayList(p1.getId()), false);
-        sink.init(new TUniqueId(1, 2), 3, 4, 1000, 1, false, false);
+        sink.init(new TUniqueId(1, 2), 3, 4, 1000, 1, false, false, false);

Review Comment:
   Is it possiable to add sume UT to cover the logics you added in 
OlatTableSink(L193)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to