morningman commented on code in PR #24207:
URL: https://github.com/apache/doris/pull/24207#discussion_r1323907766
##########
be/src/vec/data_types/serde/data_type_nullable_serde.cpp:
##########
@@ -117,24 +119,25 @@ Status
DataTypeNullableSerDe::deserialize_column_from_hive_text_vector(IColumn&
}
Status DataTypeNullableSerDe::deserialize_one_cell_from_json(IColumn& column,
Slice& slice,
- const
FormatOptions& options) const {
+ const
FormatOptions& options,
+ int
nesting_level) const {
auto& null_column = assert_cast<ColumnNullable&>(column);
// TODO(Amory) make null literal configurable
if (!(options.converted_from_string && slice.trim_quote())) {
//for map<string,string> type : {"abc","NULL"} , the NULL is string ,
instead of null values
- if (slice.size == 4 && slice[0] == 'N' && slice[1] == 'U' && slice[2]
== 'L' &&
- slice[3] == 'L') {
+ if (nesting_level >= 2 && slice.size == 4 && slice[0] == 'n' &&
slice[1] == 'u' &&
Review Comment:
Add comment to describe the logic here. Better give some example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
