morrySnow commented on code in PR #23121:
URL: https://github.com/apache/doris/pull/23121#discussion_r1323884956
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -1662,6 +1683,16 @@ public Expression
visitParenthesizedExpression(ParenthesizedExpressionContext ct
return getExpression(ctx.expression());
}
+ @Override
+ public Expression visitRowConstructor(RowConstructorContext ctx) {
+ return new Row(ctx.namedExpression().stream()
Review Comment:
since we do not support (a, b, c) to construct a struct, return a
`OneRowRelation` in from `RowConstructorContext` is better
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -2322,4 +2356,20 @@ private String parseConstant(ConstantContext context) {
public Object visitCollate(CollateContext ctx) {
return visit(ctx.primaryExpression());
}
+
+ private static class Row extends Expression {
Review Comment:
why resolve this comment, but no comment on Row be added?
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -396,6 +397,11 @@ aggTypeDef
tabletList
: TABLET LEFT_PAREN tabletIdList+=INTEGER_VALUE (COMMA
tabletIdList+=INTEGER_VALUE)* RIGHT_PAREN
;
+
+
+inlineTable
+ : VALUES rowConstructor (COMMA rowConstructor)* tableAlias
Review Comment:
i think `tableAlias` should be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
