xiaokang commented on code in PR #23931:
URL: https://github.com/apache/doris/pull/23931#discussion_r1323856514
##########
be/src/vec/functions/simple_function_factory.h:
##########
@@ -164,12 +164,22 @@ class SimpleFunctionFactory {
// if function is variadic, added types_str as key
if (function_variadic_set.count(key_str)) {
- for (auto& arg : arguments) {
- key_str.append(arg.type->is_nullable()
- ? reinterpret_cast<const
DataTypeNullable*>(arg.type.get())
- ->get_nested_type()
- ->get_family_name()
- : arg.type->get_family_name());
+ if (key_str == "json_extract") {
Review Comment:
We should avoid special branch for specific function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
