zhannngchen commented on code in PR #24191:
URL: https://github.com/apache/doris/pull/24191#discussion_r1322475919
##########
be/src/runtime/runtime_state.h:
##########
@@ -285,6 +285,10 @@ class RuntimeState {
_num_rows_filtered_in_strict_mode_partial_update += num_rows;
}
+ void set_num_rows_filtered_in_strict_mode_partial_update(int64_t num_rows)
{
Review Comment:
`update_num_rows_filtered_in_strict_mode_partial_update` should removed？
##########
be/src/vec/sink/vtablet_sink.cpp:
##########
@@ -1128,6 +1175,7 @@ Status VOlapTableSink::prepare(RuntimeState* state) {
tablet_with_partition.partition_id = part->id;
tablet_with_partition.tablet_id = tablet;
tablets.emplace_back(std::move(tablet_with_partition));
+ LOG(INFO) << "[partition_id:" << part->id << "][tablet_id:" <<
tablet << "]";
Review Comment:
should be removed?
##########
be/src/runtime/runtime_state.h:
##########
@@ -285,6 +285,10 @@ class RuntimeState {
_num_rows_filtered_in_strict_mode_partial_update += num_rows;
}
+ void set_num_rows_filtered_in_strict_mode_partial_update(int64_t num_rows)
{
Review Comment:
`update_num_rows_filtered_in_strict_mode_partial_update` should removed？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
