HappenLee commented on a change in pull request #4699:
URL: https://github.com/apache/incubator-doris/pull/4699#discussion_r502784173



##########
File path: fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java
##########
@@ -377,6 +408,17 @@ private void processRename(Database db, OlapTable table, 
List<AlterClause> alter
         }
     }
 
+    private void processRename(Database db, Table table, List<AlterClause> 
alterClauses) throws DdlException {

Review comment:
       @wuyunfeng hi,yunfeng. I just want keep the function name same to the 
olaptable alter function name. 

##########
File path: 
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
##########
@@ -132,6 +132,26 @@ private void processAddColumn(AddColumnClause alterClause, 
OlapTable olapTable,
                           indexSchemaMap, newColNameSet);
     }
 
+    private void processAddColumn(AddColumnClause alterClause, Table 
externalTable, List<Column> newSchema) throws DdlException {

Review comment:
       hi,yunfeng. I just want keep the function name same to the olaptable 
alter function name. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to