mymeiyi commented on code in PR #23053: URL: https://github.com/apache/doris/pull/23053#discussion_r1322297526
########## be/src/vec/sink/vtablet_sink.cpp: ########## @@ -1139,6 +1144,10 @@ Status VOlapTableSink::prepare(RuntimeState* state) { } // Prepare the exprs to run. RETURN_IF_ERROR(vectorized::VExpr::prepare(_output_vexpr_ctxs, state, _row_desc)); + if (_group_commit) { Review Comment: It's better to move it to group_commit_tablet_sink -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org