zhannngchen commented on code in PR #24165:
URL: https://github.com/apache/doris/pull/24165#discussion_r1321447131
##########
be/src/olap/rowset/segment_v2/binary_prefix_page.cpp:
##########
@@ -202,7 +202,13 @@ Status
BinaryPrefixPageDecoder::seek_at_or_after_value(const void* value, bool*
return Status::OK();
}
_cur_pos++;
- RETURN_IF_ERROR(_read_next_value());
+ auto st = _read_next_value();
+ if (st.is<ErrorCode::END_OF_FILE>()) {
+ return Status::Error<ErrorCode::ENTRY_NOT_FOUND>("all value small
than the value");
+ }
+ if (!st.ok()) {
+ return st;
+ }
}
Review Comment:
should return a Status::OK() at the end of this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
