HappenLee commented on code in PR #23972:
URL: https://github.com/apache/doris/pull/23972#discussion_r1320940462
##########
be/src/vec/common/hash_table/ph_hash_map.h:
##########
@@ -178,14 +178,18 @@ class PHHashMap : private boost::noncopyable {
}
template <typename KeyHolder>
- void ALWAYS_INLINE emplace(KeyHolder&& key_holder, LookupResult& it,
size_t hash_value,
- bool& inserted) {
+ void ALWAYS_INLINE emplace(KeyHolder&& key_holder, LookupResult& it, bool&
inserted,
Review Comment:
why change the order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
