mrhhsg commented on code in PR #24101:
URL: https://github.com/apache/doris/pull/24101#discussion_r1319636088
##########
be/src/pipeline/exec/hashjoin_build_sink.cpp:
##########
@@ -173,6 +173,7 @@ Status
HashJoinBuildSinkLocalState::process_build_block(RuntimeState* state,
[&](std::monostate& arg, auto has_null_value,
auto short_circuit_for_null_in_build_side) -> Status {
LOG(FATAL) << "FATAL: uninited hash table";
+ LOG(FATAL) << "__builtin_unreachable";
Review Comment:
Dumplicated fatal log.
##########
be/src/pipeline/exec/hashjoin_build_sink.cpp:
##########
@@ -496,6 +498,7 @@ Status HashJoinBuildSinkOperatorX::sink(RuntimeState*
state, vectorized::Block*
}
auto ret = std::visit(Overload {[&](std::monostate&) -> Status {
LOG(FATAL) << "FATAL: uninited
hash table";
+ LOG(FATAL) <<
"__builtin_unreachable";
Review Comment:
Dumplicated
##########
be/src/vec/columns/column.h:
##########
@@ -152,6 +152,7 @@ class IColumn : public COW<IColumn> {
// todo(Amory) from column to get data type is not correct ,column is
memory data,can not to assume memory data belong to which data type
virtual TypeIndex get_data_type() const {
LOG(FATAL) << "Cannot get_data_type() column " << get_name();
+ LOG(FATAL) << "__builtin_unreachable";
Review Comment:
Duplicated
##########
be/src/pipeline/exec/hashjoin_build_sink.cpp:
##########
@@ -355,6 +356,7 @@ void
HashJoinBuildSinkLocalState::_hash_table_init(RuntimeState* state) {
std::visit(vectorized::Overload {[&](std::monostate& arg) {
LOG(FATAL) << "FATAL: uninited hash
table";
+ LOG(FATAL) << "__builtin_unreachable";
Review Comment:
Duplicated
##########
be/src/pipeline/exec/hashjoin_build_sink.cpp:
##########
@@ -552,6 +555,7 @@ Status HashJoinBuildSinkOperatorX::sink(RuntimeState*
state, vectorized::Block*
Overload {
[&](std::monostate&) -> Status {
LOG(FATAL) << "FATAL: uninited hash table";
+ LOG(FATAL) << "__builtin_unreachable";
Review Comment:
Duplicated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
