[GitHub] [doris] Tech-Circle-48 commented on a diff in pull request #23981: [Enhancement]The page cache can be parameterized by the session variable of fe.

[via GitHub]

Tech-Circle-48 commented on code in PR #23981:
URL: https://github.com/apache/doris/pull/23981#discussion_r1318030269


##########
be/src/vec/exec/scan/new_olap_scanner.cpp:
##########
@@ -412,7 +412,7 @@ Status NewOlapScanner::_init_tablet_reader_params(
         }
     }
 
-    if (!config::disable_storage_page_cache) {
+    if (_state->enable_page_cache()) {
         _tablet_reader_params.use_page_cache = true;
     }

Review Comment:
   already modifed，Indeed it should, add be to check the configuration passed 
by fe



##########
be/src/vec/exec/scan/new_olap_scanner.cpp:
##########
@@ -412,7 +412,7 @@ Status NewOlapScanner::_init_tablet_reader_params(
         }
     }
 
-    if (!config::disable_storage_page_cache) {
+    if (_state->enable_page_cache()) {
         _tablet_reader_params.use_page_cache = true;
     }

Review Comment:
   already modifed，Indeed it should, add be to check the configuration passed 
by fe



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org